Fix handling of PTYs when renderer is reloaded #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Persist processes if error code is "GoingAway" - Switch the shell websocket handling to use v8's serialization functions and full objects instead of Base64 and single character channel names. This should help readability of the code. - Add documentation for WebSocketApiParams Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com> Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
requested review from
nevalla and
jim-docker
and removed request for
a team
|
My terminal doesn't open at all now:
No "Connecting...", nothing in the logs, just flashing cursor. Works fine on master tried on mac and linux, same problem |
Signed-off-by: Sebastian Malton <sebastian@malton.name>
|
@jim-docker Fixed. |
|
I'm still seeing unresponsive terminals. I open 3 terminals, disconnect/reconnect the cluster and one or two of them just have a blinking cursor (no prompt, don't take input). I can see "Connecting.." flash briefly and then just the cursor. |
|
logs indicate that the session is resumed (always see this for each terminal) |
|
Will investigate |
|
Why not just kill all the terminal processes upon cluster disconnect? |
That should already be happening, but that isn't what the problem is. |
- Shell sessions are now not persisted if the cluster is disconnected - On reconnect, fake the last data message being sent so that the terminal is not empty Signed-off-by: Sebastian Malton <sebastian@malton.name>
… killed Signed-off-by: Sebastian Malton <sebastian@malton.name>
jim-docker
approved these changes
Nov 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist processes if error code is "GoingAway"
Switch the shell websocket handling to use v8's serialization
functions and full objects instead of Base64 and single character
channel names. This should help readability of the code.
Add documentation for WebSocketApiParams
Signed-off-by: Jari Kolehmainen jari.kolehmainen@gmail.com
Signed-off-by: Sebastian Malton sebastian@malton.name
fixes #4318