Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update built-in extensions package-lock.json #4368

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

ixrock
Copy link
Contributor

@ixrock ixrock commented Nov 17, 2021

Motivation: each time make dev or yarn dev creates uncommitted files (similar thing as yarn.lock)

Signed-off-by: Roman <ixrock@gmail.com>
@ixrock ixrock requested a review from a team as a code owner November 17, 2021 11:38
@ixrock ixrock requested review from jakolehm and jim-docker and removed request for a team November 17, 2021 11:38
@ixrock ixrock added chore enhancement New feature or request labels Nov 17, 2021
@ixrock ixrock requested review from Nokel81 and msa0311 November 17, 2021 11:39
@ixrock ixrock removed the enhancement New feature or request label Nov 17, 2021
@panuhorsmalahti
Copy link
Contributor

Does this solve the root cause? Maybe in few days/weeks the package-lock files start to change again?

@ixrock
Copy link
Contributor Author

ixrock commented Nov 17, 2021

Does this solve the root cause? Maybe in few days/weeks the package-lock files start to change again?

I guess it happens only when changes some of dependencies from these packages, no?
So each time extension's dep(s) changed these lock files must be committed too AFAIK (same as we commit yarn.lock)

@ixrock ixrock merged commit 7b68c08 into master Nov 18, 2021
@ixrock ixrock deleted the extensions/update_package_locks branch November 18, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants