Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX for shell env sync failure #6644

Merged
merged 3 commits into from
Nov 25, 2022
Merged

Improve UX for shell env sync failure #6644

merged 3 commits into from
Nov 25, 2022

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Nov 24, 2022

Signed-off-by: Sebastian Malton sebastian@malton.name

  1. Add a notification when it fails
  2. Add a case for when the output does not have the expected shape.

@Nokel81
Move files to be under a feature folder
cce8ec5 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Add error notification on shell sync failure
632365a 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
Improve error handling of case where match is not found
10d44aa 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 added the enhancement New feature or request label Nov 24, 2022
@Nokel81 Nokel81 added this to the 6.2.3 milestone Nov 24, 2022
@Nokel81 Nokel81 requested a review from a team as a code owner November 24, 2022 18:28
@Nokel81 Nokel81 requested review from aleksfront and jim-docker and removed request for a team November 24, 2022 18:28
aleksfront
aleksfront approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nokel81 Nokel81 modified the milestones: 6.2.3, 6.3.0 Nov 25, 2022
@Nokel81 Nokel81 merged commit 65b14b9 into master Nov 25, 2022
@Nokel81 Nokel81 deleted the improve-shell-sync-UX branch November 25, 2022 12:53
@Nokel81 Nokel81 mentioned this pull request Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksfront aleksfront aleksfront approved these changes

@jim-docker jim-docker Awaiting requested review from jim-docker jim-docker is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Nokel81 @aleksfront