Fix extensions using "application" as magic string for preference tab #6666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncesTab" Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Iku-turso
requested review from
ixrock and
aleksfront
and removed request for
a team
Iku-turso
commented
Nov 29, 2022
...renderer/compliance-for-legacy-extension-api/registrator-for-preference-items.injectable.tsx
Show resolved
Hide resolved
Nokel81
approved these changes
Nov 29, 2022
Iku-turso
added a commit
that referenced
this pull request
Nov 30, 2022
…#6666) Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Merged
Iku-turso
added a commit
that referenced
this pull request
Nov 30, 2022
* Release 6.2.4 Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Bump electron from 19.1.7 to 19.1.8 (#6664) Bumps [electron](https://github.com/electron/electron) from 19.1.7 to 19.1.8. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v19.1.7...v19.1.8) --- updated-dependencies: - dependency-name: electron dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix extensions using "application" as magic string for preference tab (#6666) Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> * Make preferences from extensions using tabs "application" and "telemetry" appear as last (#6674) Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> Signed-off-by: Iku-turso <mikko.aspiala@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.