Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using custom properties for z-index values #6733

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Using custom properties for z-index values #6733

merged 5 commits into from
Dec 13, 2022

Conversation

aleksfront
Copy link
Contributor

@aleksfront aleksfront commented Dec 12, 2022 •
edited
Loading

Create new and manage available stacking contexts for new elements became difficult. It's hard to select proper z-index value for the element which cover other elements because there are many z-indexes may overlap each other.

Providing css custom properties in app.scss in order to fight with arbitrary z-index values spread across codebase. It is encouraged to use these properties for any new pages or elements if needed.

// app.scss
--z-index-base: 0;
--z-index-above: 1;
--z-index-modals: 2;
--z-index-menus: 3;
--z-index-topmost: 9999;

settings
hotbar

dialog.mov

namespace filter

Signed-off-by: Alex Andreev alex.andreev.email@gmail.com

@aleksfront
Using custom properties for z-index values
8d2f007 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Reorder values
0e8714f 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront added this to the 6.2.6 milestone Dec 12, 2022
@aleksfront aleksfront requested a review from ixrock December 12, 2022 10:15
@aleksfront aleksfront requested a review from a team as a code owner December 12, 2022 10:15
@aleksfront aleksfront requested review from jansav and removed request for a team December 12, 2022 10:15
@aleksfront
Remove unused styles
27f58e1 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
ixrock previously approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@ixrock ixrock left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea for better management of UI layers LGTM, some naming changes might require to apply.

src/renderer/components/+namespaces/namespace-select-filter.scss Show resolved Hide resolved
src/renderer/components/+welcome/welcome.scss Show resolved Hide resolved
src/renderer/components/cluster-manager/cluster-manager.scss Show resolved Hide resolved
src/renderer/components/dialog/dialog.scss Outdated Show resolved Hide resolved
src/renderer/components/dock/dock.scss Show resolved Hide resolved
src/renderer/components/hotbar/hotbar-menu.scss Show resolved Hide resolved
src/renderer/components/layout/main-layout.module.scss Show resolved Hide resolved
src/renderer/components/layout/setting-layout.scss Outdated Show resolved Hide resolved
@aleksfront
Different set of z-index css vars
b96cfc9 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront requested a review from ixrock December 13, 2022 09:48
@aleksfront
Revert z-index to main layout
a91f4d2 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront modified the milestones: 6.2.6, 6.3.0 Dec 13, 2022
ixrock
ixrock approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@ixrock ixrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleksfront aleksfront merged commit 4af8fba into master Dec 13, 2022
@aleksfront aleksfront deleted the enhancement-z-index-order branch December 13, 2022 13:36
@aleksfront aleksfront mentioned this pull request Dec 19, 2022
Merged
@Nokel81 Nokel81 mentioned this pull request Dec 20, 2022
Merged
aleksfront added a commit that referenced this pull request Dec 22, 2022
@aleksfront
Revert "Using custom properties for z-index values (#6733)"
2106fa3 
This reverts commit 4af8fba.

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Nokel81 pushed a commit that referenced this pull request Dec 22, 2022
@aleksfront
Revert #6733 to avoid breaking changes for extensions (#6821)
da267a9 
This reverts commit 4af8fba.

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@Nokel81 Nokel81 mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixrock ixrock ixrock approved these changes

@jansav jansav Awaiting requested review from jansav jansav is a code owner automatically assigned from lensapp/lens-ide

@jim-docker jim-docker Awaiting requested review from jim-docker

Assignees
No one assigned
Labels
area/ui chore
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksfront @ixrock