Renderer logging to file #6740
Closed
Renderer logging to file #6740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samitiilikainen
requested review from
aleksfront
and removed request for
a team
jakolehm
reviewed
Dec 13, 2022
| instantiate: (di) => { | ||
| const logger = di.inject(loggerInjectable) as winston.Logger; | ||
|
|
||
| return logger.add(new transports.File({ |
There was a problem hiding this comment.
Just a note that writing logs to filesystem from renderer caused issues in the past. Not sure if it is still the case...
There was a problem hiding this comment.
That is a good point, do we know if this transport uses async or sync FS calls?
There was a problem hiding this comment.
Winston file transport is using async fs.createWriteStream
There was a problem hiding this comment.
I think after #6690 is merged this will be simpler.
Also, I think that we should include the clusterId in the file name so that we don't have multiple frames writing to the same file.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/lensapp/support-lens-extension/issues/118