Fix typing of ExtensionStore.createInstance static #6764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
added
bug
Nokel81
requested review from
jansav and
aleksfront
and removed request for
a team
jim-docker
approved these changes
Dec 15, 2022
Comment on lines
+30
to
+35
| private static readonly instances = new WeakMap<object, any>(); | ||
|
|
||
| /** | ||
| * @deprecated This is a form of global shared state. Just call `new Store(...)` | ||
| */ | ||
| static createInstance<T extends ExtensionStore<object>, R extends any[]>(this: StaticThis<T, R>, ...args: R): T { | ||
| static createInstance<T, R extends any[]>(this: StaticThis<T, R>, ...args: R): T { |
There was a problem hiding this comment.
Is this just reverting changes made in #6690, or are they typing changes needed because of refactoring there?
There was a problem hiding this comment.
So in that PR I removed the extends Singleton from Basestore so to keep the same API of ExtensionStore I added the static methods here (because JS doesn't have multiple inheritance).
The ones on Singleton have T extends Singleton which is why I initially added the T extends ExtensionStore<object>, just it wasn't actually needed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Malton sebastian@malton.name
Regression from #6690