Allow main send messages to cluster frames #6835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
jansav
requested review from
Nokel81 and
aleksfront
and removed request for
a team
jansav
changed the title
jansav
changed the title
jakolehm
approved these changes
Dec 27, 2022
This was referenced Jan 3, 2023
This was referenced Jan 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR channel abstraction was not ready to be used for communicating from
maintocluster-frame.This was postponed since initial idea was to get rid of
cluster-framebefore we start using channel abstraction more.However #6690 switched the base store to use Channel abstraction for syncing stores between processes. That broke all syncing from
maintocluster-frame, meaning that we had to implement it in channel abstraction.Fixes #6829