Fix KubeJsonApi.forCluster missing from extension API and remove class constructors that require dependencies #6947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make sure that dependency constructors are not exported - Readd `KubeJsonApi.forCluster` Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
added
bug
Nokel81
requested review from
ixrock and
aleksfront
and removed request for
a team
| } from "../../common/k8s-api/kube-json-api"; | ||
|
|
||
| function KubeJsonApiCstr(config: JsonApiConfig, reqInit?: RequestInit) { |
There was a problem hiding this comment.
Does Cstr stand for Constructor? Maybe avoid abbreviation for clarity?
There was a problem hiding this comment.
Sure, that function isn't exposed to the extension API at all. Just an an internal implementation to this file.
panuhorsmalahti
approved these changes
Jan 16, 2023
Merged
Nokel81
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KubeJsonApi.forClusterSigned-off-by: Sebastian Malton sebastian@malton.name