Better visibility of updating global namespace from resource listing views #6962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resource views with excessive dependencies (e.g updating global namespace filter) - better UX to and visibility for user on click action (sometimes namespace-filter might not be visible in app/UI) Signed-off-by: Roman <ixrock@gmail.com>
ixrock
requested review from
aleksfront,
3lodie and
Nokel81
and removed request for
a team and
3lodie
…fected helm-charts/releases Signed-off-by: Roman <ixrock@gmail.com>
|
@Nokel81 please re-approve, tests fixed for now |
Nokel81
approved these changes
Jan 18, 2023
ixrock
added a commit
that referenced
this pull request
Jan 18, 2023
…- part 2, follow up #6962 Signed-off-by: Roman <ixrock@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new component
<NamespaceSelectBadge/>refactored out from multiple resource views with excessive dependencies (e.g updating global namespace filter injectable imported everywhere)better UX and visibility for clicked actions (sometimes namespace-filter might not be visible in UI or click could be done accidentally)
Before:
After: