Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set core webpack dependencies as externals #7094

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Set core webpack dependencies as externals #7094

merged 2 commits into from
Feb 2, 2023

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Feb 2, 2023

  • configures core package dependencies as externals for webpack
  • cleans up core webpack configuration (it was a mess)
  • removes unused webpack plugins from core

Related to #7065

@jakolehm
core webpack dependencies as externals
bd4e513 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm added bug Something isn't working area/build labels Feb 2, 2023
@jakolehm jakolehm added this to the 6.4.0 milestone Feb 2, 2023
@jakolehm jakolehm requested review from jansav and Nokel81 February 2, 2023 12:59
@jakolehm jakolehm requested a review from a team as a code owner February 2, 2023 12:59
jansav
jansav previously approved these changes Feb 2, 2023
View reviewed changes
jansav
jansav reviewed Feb 2, 2023
View reviewed changes
packages/core/webpack/renderer.ts
"win-ca": "commonjs win-ca",
},
...additionalExternals,
nodeExternals(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix.

@jakolehm
use fork-ts-checker-webpack-plugin
ed38082 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm merged commit 5002b45 into master Feb 2, 2023
@jakolehm jakolehm deleted the core-webpack-deps-as-external branch February 2, 2023 14:52
This was referenced Feb 3, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansav jansav jansav left review comments

@Nokel81 Nokel81 Nokel81 approved these changes

Assignees
No one assigned
Labels
area/build bug Something isn't working
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jakolehm @jansav @Nokel81