Keep up-to-date resource in the details view (Drawer) #7224
Conversation
Signed-off-by: Roman <ixrock@gmail.com>
ixrock
requested review from
jansav,
Nokel81,
aleksfront and
Iku-turso
and removed request for
a team
Signed-off-by: Roman <ixrock@gmail.com>
… wrong Signed-off-by: Roman <ixrock@gmail.com>
ixrock
force-pushed
the
fix/keep_fresh_resource_in_details_view
branch
from
c01579c to
b4e17f5
Compare
My favourite kind of fix, small and precise. @Nokel81 Could this make it for 6.4.0? |
| @@ -100,7 +103,8 @@ describe("reactively hide kube object detail item", () => { | |||
| expect(rendered.baseElement).toMatchSnapshot(); | |||
| }); | |||
|
|
|||
| it("shows the kube object detail item", () => { | |||
| // FIXME: details not rendered in the Drawer (in snapshot?) | |||
There was a problem hiding this comment.
It's a bit worrisome that some tests no longer pass though?
Don't want to with those tests being skipped |
This doesn't look right for a snapshot |
…urce_in_details_view
…urce_in_details_view
| @@ -33,6 +41,8 @@ describe("reactively hide kube object detail item", () => { | |||
| const store = { | |||
| api, | |||
| loadFromPath: async () => getKubeObjectStub("some-kind", "some-api-version"), | |||
| getByPath() { | |||
There was a problem hiding this comment.
If I comment this line I'm getting very uninformative/misleading error description.. Can we improve that somehow?
Why there is nothing about that store.getByPath(path: string) not available?
There was a problem hiding this comment.
Because the error is within a render call and is being swallowed by ErrorBoundary. If you look at the snapshot you will see the DOM with the error. I agree it is a bit annoying.
|
@Nokel81 tests are fixed, PTAL |
* alternative to #7187 Signed-off-by: Roman <ixrock@gmail.com> * update snapshots with `jest src -u` from `packages/core` Signed-off-by: Roman <ixrock@gmail.com> * skipping some tests cause i have no idea how to fix those and what is wrong Signed-off-by: Roman <ixrock@gmail.com> * fix tests Signed-off-by: Roman <ixrock@gmail.com> --------- Signed-off-by: Roman <ixrock@gmail.com> Signed-off-by: Gabriel <gaccettola@mirantis.com>
Minimal alternative to #7187
Fix #7186
Screen.Recording.2023-02-17.at.16.24.33.mov