Respect cluster avatars entity background color #7365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
ixrock
suggested changes
Mar 16, 2023
packages/core/src/renderer/components/hotbar/hotbar-entity-icon.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Nokel81
approved these changes
Mar 16, 2023
ixrock
approved these changes
Mar 17, 2023
Nokel81
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Add iconBackgroundColor cluster preference type Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Set custom backround for hotbar entities Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Remove unused code from Catalog Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Update entity background if preferences background changes Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Set avatar backgrounds from entity Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Clean up Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Clean up in hotbar entity icon Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Fix setting up entity background Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Use single icon prop Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Cleaning up hotbar entity icon Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Fixing test to ensure icon has data:image Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Add more test cases Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> --------- Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
gabriel-mirantis
pushed a commit
that referenced
this pull request
Mar 21, 2023
* Add iconBackgroundColor cluster preference type Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Set custom backround for hotbar entities Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Remove unused code from Catalog Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Update entity background if preferences background changes Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Set avatar backgrounds from entity Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Clean up Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Clean up in hotbar entity icon Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Fix setting up entity background Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Use single icon prop Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Cleaning up hotbar entity icon Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Fixing test to ensure icon has data:image Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> * Add more test cases Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> --------- Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com> Signed-off-by: Gabriel <gaccettola@mirantis.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #3846
First part #7349
All cluster icons updated if
backgroundColorchanged in cluster preferences.