Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in CI about documentation #7582

Merged
merged 5 commits into from
Apr 19, 2023
Merged

Fix errors in CI about documentation #7582

merged 5 commits into from
Apr 19, 2023

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Apr 19, 2023

Signed-off-by: Sebastian Malton sebastian@malton.name

Nokel81 added 4 commits April 19, 2023 09:43
@Nokel81
chore: Bump typedoc and typedoc-plugin-markdown
4533f74 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
docs: Fix generating docs
d64c7d5 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
docs: Fix initial warnings from generating API docs
8e7853e 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81
docs: Fix generating markdown for api docs
1852bc6 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 requested a review from a team as a code owner April 19, 2023 14:49
@Nokel81 Nokel81 requested review from Iku-turso and jim-docker and removed request for a team April 19, 2023 14:49
@Nokel81 Nokel81 linked an issue Apr 19, 2023 that may be closed by this pull request
Generating API docs are failing #7581
Closed
@Nokel81 Nokel81 added this to the 6.5.0 milestone Apr 19, 2023
@Nokel81
chore: Update package-lock to fix CI
ee42749 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
@Nokel81 Nokel81 merged commit 1eeddbb into master Apr 19, 2023
@Nokel81 Nokel81 deleted the fix-documentation-failure branch April 19, 2023 16:42
@jim-docker
Copy link
Contributor

Trying to test, running npm run mkdocs:verify or npm run mkdocs:serve-local both lead to

Error: Config file 'mkdocs.yml' does not exist.

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Apr 19, 2023 •
edited
Loading

How do you have docker set up? I didn't get it to work using the docker CLI feature in Lens Desktop, I needed to install mkdocs locally

@jim-docker
Copy link
Contributor

I'm using the docker daemon from minikube

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Apr 19, 2023

Following https://apple.stackexchange.com/a/439938 worked for me just now. Might be a configuration issue

@Nokel81 Nokel81 mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-mirantis gabriel-mirantis gabriel-mirantis approved these changes

@Iku-turso Iku-turso Awaiting requested review from Iku-turso Iku-turso is a code owner automatically assigned from lensapp/lens-ide

@jim-docker jim-docker Awaiting requested review from jim-docker jim-docker is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

Generating API docs are failing
3 participants
@Nokel81 @jim-docker @gabriel-mirantis