fix: Retrieve projectVersion from main for 'extensions-persistent-storage' #7806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nokel81
commented
May 30, 2023
Nokel81
commented
- Prevent the version being changed by the renderer
Nokel81
requested review from
aleksfront and
jim-docker
and removed request for
a team
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jim-docker
reviewed
May 30, 2023
packages/core/src/features/extensions/enabled/main/storage-version.injectable.ts
Outdated
Show resolved
Hide resolved
…rage' - Prevent the version being changed by the renderer Signed-off-by: Sebastian Malton <sebastian@malton.name>
jim-docker
reviewed
May 30, 2023
packages/core/src/features/extensions/enabled/common/storage.injectable.ts
Show resolved
Hide resolved
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Nokel81
force-pushed
the
fix-extensions-storage-failure
branch
from
90381af
to
fe75c81
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.