Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change apiVersion CronJob from batch/v1beta1 to batch/v1 #7953

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

change apiVersion CronJob from batch/v1beta1 to batch/v1 #7953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core/src/renderer/components/__tests__/cronjob.store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const scheduledCronJob = new CronJob({
resourceVersion: "scheduledCronJob",
uid: "scheduledCronJob",
namespace: "default",
selfLink: "/apis/batch/v1beta1/cronjobs/default/scheduledCronJob",
selfLink: "/apis/batch/v1/cronjobs/default/scheduledCronJob",
},
spec: {
schedule: "test",
Expand Down Expand Up @@ -55,7 +55,7 @@ const suspendedCronJob = new CronJob({
resourceVersion: "suspendedCronJob",
uid: "suspendedCronJob",
namespace: "default",
selfLink: "/apis/batch/v1beta1/cronjobs/default/suspendedCronJob",
selfLink: "/apis/batch/v1/cronjobs/default/suspendedCronJob",
},
spec: {
schedule: "test",
Expand Down Expand Up @@ -90,7 +90,7 @@ const otherSuspendedCronJob = new CronJob({
resourceVersion: "otherSuspendedCronJob",
uid: "otherSuspendedCronJob",
namespace: "default",
selfLink: "/apis/batch/v1beta1/cronjobs/default/otherSuspendedCronJob",
selfLink: "/apis/batch/v1/cronjobs/default/otherSuspendedCronJob",
},
spec: {
schedule: "test",
Expand Down
2 changes: 1 addition & 1 deletion ...bject-details/kube-object-detail-items/implementations/cron-job-detail-item.injectable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ const cronJobDetailItemInjectable = getInjectable({
export default cronJobDetailItemInjectable;

export const isCronJob = kubeObjectMatchesToKindAndApiVersion("CronJob", [
"batch/v1beta1",
"batch/v1",
]);
2 changes: 1 addition & 1 deletion packages/resource-templates/templates/create-resource/CronJob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: batch/v1beta1
apiVersion: batch/v1
kind: CronJob
metadata:
name: hello
Expand Down