Allow to run node shell on Bootlerocket and Windows nodes #7965
+94
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reworked node-shell feature. It allows to run it on Bottlerocket OS and Windows nodes where there is no
sh
norbash
command.Unfortunately, node-shell pods cannot be autoremoved anymore with
sleep
command. It is because now single pod is created and thenkubectl attach
is run. It is becausekubectl exec
withnsenter
command won't work: Bottlerocket OS is SELinux hardened thennsenter
won't have privileges to run inkubectl exec
context.Anyway: node-shell pods are correctly removed after the terminal is closed.
Because Windows needs separate image, there is a separate setting now:
Node shell for Ubuntu:
Node shell for Bottlerocket:
Node shell for Windows 2022: