Fix rlua - lua51 not building #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavyakukkar
force-pushed
the
bugfix/build_rlua_lua51
branch
from
7a8413b to
23ea309
Compare
|
Can you rebase it onto master? I fixed the clippy errors. And thanks for the PR, sorry it took a while to get to it. |
- Excluded rlua::Value::Integer for tealr features rlua_builtin-lua51 & rlua_system-lua51 since it is available in lua 5.3+ only as mentioned here: https://github.com/mlua-rs/rlua/blob/6152008989fb43a63c0632dc39dea25f40390ac9/src/value.rs#L31 - Implemented as excluding for lua51 instead of including for lua53, 54 so that future lua versions wouldn't require rechanging.
bhavyakukkar
force-pushed
the
bugfix/build_rlua_lua51
branch
from
23ea309 to
6113540
Compare
|
@lenscas done. all 6 examples still build |
|
Awesome. Merged it. Thank you for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rlua::Value::Integeris only available in lua 5.3+ as mentioned here.This commit fixes tealr not building at all for flags
rlua_builtin-lua51andrlua_system-lua51.Before this commit:
After this commit, all of these build successfully: