Alpha v2 #3
Open
Alpha v2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le and only change fan speed when required. Sends information to kernel when the fan speed changes.
…y one parameter that indicates the device to control.
Change how log is sent to kernel (date is not required).
…together. Scripts are recoded as library
…whith minor changes mainly related to convert the script on library. New feature added to send fan changes to kernel, and only change fan speed when required.
Move som variables to lowercase to easily reading. Removed some testing routines. Put set_led function calls sincronous because blink calls are asyncronous yet. Change blkink_leds function name to set_leds to easy reading of main daemon.
Removed old_status line that are obsolete.
Configuration file to easily change parameters without change the code itself.
Adding the new daemon that substitue the old fan-daemon. Minor changes on files in order to fit new names.
Added descriptions about what the daemon currently does.
| #tmppath="/run/dns-nas-utils" | ||
|
|
||
| # Default fan device | ||
| #fan_device="/sys/devices/gpio_fan/hwmon/hwmon0/fan1_target" |
There was a problem hiding this comment.
👍 My DNS has different path to the fan. It is great that I can configure it from here!
There was a problem hiding this comment.
@dobiatowski What's the path? Adding various paths to search for is probably a good idea. Or it could be the default is just wrong nowadays.
There was a problem hiding this comment.
Hi guys,
In my DNS320 (old version) this path is the correct, but probably in the newer version or others the path is different.
I'm thinkint onto create a dialog assistant to configure with dpkg the dns-nas-utils.conf
What do you think about this?
…d from any arbitrary location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jamie
Here is my v2 proposal it includes your fan control, a hdd_led control and disk power state monitor.
The main daemon are entirely remastered but your daemon are near to be identical to the original but converted as a library.
Thank you.