Add missing field to pubspec #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems some tests failed. Let me know if you have it passing on your end, and I can check if anything has changed |
|
Fixed the tests from this PR. |
|
It seems the schema had changed. Will have to update it |
|
@jxstxn1 I had to do a major schema change to this might be a major version bump. Just merged into your fork, let me know if you see any regressions, but now there is a more complete schema |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing Issue #46
Adding missing values which can occur in a pubspec to the PubSpec Package using extension methods.
I implemented methods which are listed here https://dart.dev/tools/pub/pubspec, but aren't part of the PubSpec package.
Also added a set of test to make sure parsing is working as expected