Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock to version 3.2 #11

Merged
merged 2 commits into from
Aug 3, 2014
Merged

Lock to version 3.2 #11

merged 2 commits into from
Aug 3, 2014

Conversation

fny
Copy link
Contributor

@fny fny commented Jul 30, 2014

ActiveRecord Futures doesn't work ActiveRecord 4, so the dependency should be tied to version 3.2.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 346acd1 on fny:master into 17e2cdb on leoasis:master.

@fny
Copy link
Contributor Author

fny commented Jul 30, 2014

Note sure how it's possible that this build failed given that nothing really changed.

@leoasis
Copy link
Owner

leoasis commented Jul 31, 2014

Seems to be the fact that I didn't specify rspec with a version restriction, and it's using a newer version which breaks. Mind updating the gemspec with rspec version 2.13? That's the one that was used previously.

@leoasis
Copy link
Owner

leoasis commented Aug 3, 2014

Thanks for the PR!

leoasis added a commit that referenced this pull request Aug 3, 2014
@leoasis leoasis merged commit d330bfc into leoasis:master Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants