Skip to content

Remove conservative unbinding #464

Remove conservative unbinding

Remove conservative unbinding #464

Triggered via pull request January 21, 2025 23:46
Status Success
Total duration 1m 33s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
the following explicit lifetimes could be elided: 'a: src/sl/transpile.rs#L266
warning: the following explicit lifetimes could be elided: 'a --> src/sl/transpile.rs:266:6 | 266 | impl<'a> FragmentVisitor<'a, Sl> for CollectOutputs { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 266 - impl<'a> FragmentVisitor<'a, Sl> for CollectOutputs { 266 + impl FragmentVisitor<'_, Sl> for CollectOutputs { |
the following explicit lifetimes could be elided: 'a: src/sl/transpile.rs#L251
warning: the following explicit lifetimes could be elided: 'a --> src/sl/transpile.rs:251:6 | 251 | impl<'a> VertexVisitor<'a, Sl> for CollectVertexBlocks { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 251 - impl<'a> VertexVisitor<'a, Sl> for CollectVertexBlocks { 251 + impl VertexVisitor<'_, Sl> for CollectVertexBlocks { |
the following explicit lifetimes could be elided: 'a: src/sl/transpile.rs#L210
warning: the following explicit lifetimes could be elided: 'a --> src/sl/transpile.rs:210:6 | 210 | impl<'a> UniformVisitor<'a, Sl> for CollectUniforms { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 210 - impl<'a> UniformVisitor<'a, Sl> for CollectUniforms { 210 + impl UniformVisitor<'_, Sl> for CollectUniforms { |
the following explicit lifetimes could be elided: 'a: src/sl/codegen.rs#L32
warning: the following explicit lifetimes could be elided: 'a --> src/sl/codegen.rs:32:6 | 32 | impl<'a> WriteFuncContext<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 32 - impl<'a> WriteFuncContext<'a> { 32 + impl WriteFuncContext<'_> { |
this seems like a manual implementation of the non-exhaustive pattern: src/sl/sig.rs#L27
warning: this seems like a manual implementation of the non-exhaustive pattern --> src/sl/sig.rs:27:1 | 27 | / pub struct VsInput<V> { 28 | | pub vertex: V, 29 | | pub vertex_id: U32, 30 | | pub instance_id: U32, 31 | | pub(crate) _private: (), 32 | | } | |_^ | help: remove this field --> src/sl/sig.rs:31:5 | 31 | pub(crate) _private: (), | ^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive = note: `#[warn(clippy::manual_non_exhaustive)]` on by default help: use the `#[non_exhaustive]` attribute instead | 27 + #[non_exhaustive] 28 | pub struct VsInput<V> { |
the following explicit lifetimes could be elided: 'a: src/gl/raw/image.rs#L230
warning: the following explicit lifetimes could be elided: 'a --> src/gl/raw/image.rs:230:6 | 230 | impl<'a> Image<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 230 - impl<'a> Image<'a> { 230 + impl Image<'_> { |
the following explicit lifetimes could be elided: 'a: src/gl/framebuffer.rs#L129
warning: the following explicit lifetimes could be elided: 'a --> src/gl/framebuffer.rs:129:10 | 129 | impl<'a> FragmentVisitor<'a, Gl> for Visitor { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 129 - impl<'a> FragmentVisitor<'a, Gl> for Visitor { 129 + impl FragmentVisitor<'_, Gl> for Visitor { |
the following explicit lifetimes could be elided: 'a: src/gl/context.rs#L95
warning: the following explicit lifetimes could be elided: 'a --> src/gl/context.rs:95:6 | 95 | impl<'a, VSig, VFunc, FSig, FFunc> CacheDrawBuilder<'a, VSig, VFunc, FSig, FFunc> | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 95 - impl<'a, VSig, VFunc, FSig, FFunc> CacheDrawBuilder<'a, VSig, VFunc, FSig, FFunc> 95 + impl<VSig, VFunc, FSig, FFunc> CacheDrawBuilder<'_, VSig, VFunc, FSig, FFunc> |
empty line after outer attribute: src/interface/block.rs#L36
warning: empty line after outer attribute --> src/interface/block.rs:36:5 | 36 | / /// TODO: Bool in `Block`. Need to special case vertex attributes. 37 | | //type Bool: Block<Self> + ToSl<Output = sl::Bool>; 38 | | | |_ ... 43 | type Vec2: Block<Self> + ToSl<Output = sl::Vec2> + Default; | ---------------------------------------------------------- the attribute applies to this associated type | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default = help: if the empty line is unintentional remove it
function `call_func_def` is never used: src/sl/primitives.rs#L164
warning: function `call_func_def` is never used --> src/sl/primitives.rs:164:8 | 164 | pub fn call_func_def<R: Value>(def: FuncDef, args: Vec<Rc<Expr>>) -> R { | ^^^^^^^^^^^^^
method `is_empty` is never used: src/gl/raw/buffer.rs#L81
warning: method `is_empty` is never used --> src/gl/raw/buffer.rs:81:12 | 40 | impl Buffer { | ----------- method in this implementation ... 81 | pub fn is_empty(&self) -> bool { | ^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636