Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border do not match correctly if the font size if too big or small #33

Closed
tyk198 opened this issue Jul 19, 2021 · 8 comments
Closed

Border do not match correctly if the font size if too big or small #33

tyk198 opened this issue Jul 19, 2021 · 8 comments

Comments

@tyk198
Copy link

tyk198 commented Jul 19, 2021

Border work correctly when font size is normal
image

But border work incorrectly when the font size is too big
image

How should I fixed this?

@leodevbro
Copy link
Owner

Please provide detailed info:

  • Editor: Font Family
  • Editor: Font Size
  • Editor: Mouse Wheel Zoom -> ON or OFF ?
  • Window: Zoom Level

Also please make sure that if Workspace settings (or folder settings) are overriding User settings, provide Workspace settings (or folder settings).

@tyk198
Copy link
Author

tyk198 commented Jul 19, 2021

Editor: Font Family: Consolas, 'Courier New', monospace
Editor: 14
Editor: Mouse Wheel Zoom -> ON
Window: 1

@tyk198
Copy link
Author

tyk198 commented Jul 19, 2021

Changing the font size at setting does not solve the problem, does not matter at what font size, when using the mouse wheel to change font size, the bottom border will off by about one line, weather the font become smaller or bigger by using mouse wheel. However, if the font size is medium(not using mouse wheel to change it to too small or big) the border will work correctly. The top, left and right sides of border has no problem, it is just bottom does not work correctly. I always change font size to write code, so it is bothering me.

@leodevbro
Copy link
Owner

Now I see. well, it is the VSCode limitation, not a bug of Blockman.
VSCode does not give us access to line height pixel value when we zoom/unzoom with mouse wheel.

Here is the issue: microsoft/vscode#125341 (comment)

@tyk198
Copy link
Author

tyk198 commented Jul 19, 2021

So changing the zoom level of window and font size does not affect how the border work, only when changing font size with mouse wheel will affect it. Is there a way to change font size in setting by using mouse wheel?

@leodevbro
Copy link
Owner

That's interesting proposal. I'm not sure vscode API supports such functionality. You can ask this question in the vscode repo.

@tyk198
Copy link
Author

tyk198 commented Jul 19, 2021

I had found an extension to change font size with shortcut, it now works properly for me. Thank you for helping me out, this project is really helpful and amazing!

@leodevbro
Copy link
Owner

@tyk198, Very good news: I fixed the mouse wheel zoom behavior of Blockman. It should work fine now. The latest Version of Blockman is 1.4.5 (2022-01-03)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants