Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linebreaks in the footer #29

Closed
uglow opened this issue Mar 30, 2016 · 4 comments · May be fixed by satoshinakamoto007/bitcore#1119
Closed

Support linebreaks in the footer #29

uglow opened this issue Mar 30, 2016 · 4 comments · May be fixed by satoshinakamoto007/bitcore#1119
Labels
feature New features of enhancement of existing ones help wanted

Comments

@uglow
Copy link

uglow commented Mar 30, 2016

I mistakenly added a linebreak | character in my footer message, which did not get converted into a linebreak. I looked at the code - this shouldn't be too hard to add. The spec (https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit?pref=2&pli=1#heading=h.j8e4paqkfz0q) indicates you can have multiple lines in the footer.

@leonardoanalista leonardoanalista added feature New features of enhancement of existing ones help wanted labels May 17, 2016
@stieben
Copy link

stieben commented Feb 18, 2018

I would like to tackle this and have a few questions:

  1. Both breaking and footer should support line breaks with |, right?
  2. The 2nd gotcha stops being one but the example seems to be a valuable thing to keep in the README. How about a Usage section after Options?
  3. Use "|" to break new line: Should this be added to the breaking and footer messages respectively or be part of the info before the 1st question instead?
  4. Could you point me to any other file except the following that needs accompanying changes?
    a. README.md
    b. buildCommit.js
    c. cz-config-EXAMPLE.js
    d. index.js (maybe)
    e. questions.js

@leonardoanalista
Copy link
Member

@stieben Sorry for the late reply. Footer should/could behave like message body. If you add | to the body, it becomes a breakline. I think this is what this work was about.

@stieben
Copy link

stieben commented Mar 18, 2018

Thanks for the reply! So I go ahead and open a pull request?

@leonardoanalista
Copy link
Member

🎉 This issue has been resolved in version 5.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features of enhancement of existing ones help wanted
Projects
None yet
3 participants