fix: add option usePreparedCommit default false #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 2, 2022
leonardoanalista
force-pushed
the
fix-usePreparedCommit
branch
from
8f40917
to
27a5ef5
Compare
ISSUES CLOSED: #173
leonardoanalista
force-pushed
the
fix-usePreparedCommit
branch
from
27a5ef5
to
bd3af82
Compare
ISSUES CLOSED: #173
It's just pending unit test coverage. Also considering making this a breaking change since the default is now "false" for usePreparedCommit. Before it was kind of "true". I am away this week. I'll be able to write the tests mid-next week. |
|
Sounds good!, thanks man |
jan-molak
added a commit
to serenity-js/serenity-js
that referenced
this pull request
Aug 25, 2022
…ggest, interrupting the flow With the introduction of http://leoforfree/cz-customizable#122, cz-customizable pre-populates the subject and the body of the commit message with whatever values the _previous_ commit message had. When a commit message is long, this interrupts the developer workflow as a lengthy, non-editable string of text derived from the previous commit takes up all the space for the _current_ commit and confuses Inquirer CLI, which starts to render the cursor in an invalid location Related tickets: re leoforfree/cz-customizable#196, re leoforfree/cz-customizable#196
jan-molak
added a commit
to serenity-js/serenity-js
that referenced
this pull request
Aug 25, 2022
…ggest, interrupting the flow With the introduction of leoforfree/cz-customizable#122, cz-customizable pre-populates the subject and the body of the commit message with whatever values the _previous_ commit message had. When a commit message is long, this interrupts the developer workflow as a lengthy, non-editable string of text derived from the previous commit takes up all the space for the _current_ commit and confuses Inquirer CLI, which starts to render the cursor in an invalid location Related tickets: re leoforfree/cz-customizable#173, re leoforfree/cz-customizable#196
jan-molak
added a commit
to serenity-js/serenity-js
that referenced
this pull request
Aug 25, 2022
…ggest, interrupting the flow With the introduction of leoforfree/cz-customizable#122, cz-customizable pre-populates the subject and the body of the commit message with whatever values the _previous_ commit message had. When a commit message is long, this interrupts the developer workflow as a lengthy, non-editable string of text derived from the previous commit takes up all the space for the _current_ commit and confuses Inquirer CLI, which starts to render the cursor in an invalid location Related tickets: re leoforfree/cz-customizable#173, re leoforfree/cz-customizable#196
|
This issue has been bothering me, I hope this PR can be merged in time. |
|
@docker-soga I'll try to address the code coverage today so we can merge it. I think this is a breaking change as it changes the default option. |
…z-customizable into fix-usePreparedCommit
I am not sure if people use this option but it is likely to be deprecated. BREAKING CHANGE: now usePreparedCommit is false. Please update your .cz-config with usePreparedCommit: true if you like to continue using.
|
I am really thinking if we need this option |
leonardoanalista
force-pushed
the
fix-usePreparedCommit
branch
from
89e227e
to
bfe9214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: add option usePreparedCommit default false
TODO: it needs unit tests for coverage
ISSUES CLOSED: #173