Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ticket-number question #51

Conversation

smollweide
Copy link
Contributor

now users can configure a ticket-number question before the subject

ISSUES CLOSED: #50

now users can configure a ticket-number question before the subject

ISSUES CLOSED: leoforfree#50
@codecov
Copy link

codecov bot commented Jan 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4b569b8). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #51   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      5           
  Lines             ?    330           
  Branches          ?      0           
=======================================
  Hits              ?    330           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
spec/questionsSpec.js 100% <100%> (ø)
buildCommit.js 100% <100%> (ø)
questions.js 100% <100%> (ø)
spec/czCustomizableSpec.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b569b8...2d4935e. Read the comment docs.

Copy link
Member

@leonardoanalista leonardoanalista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Simon!
Thanks for the PR, I agree with most of things and happy to merge soon. I left questions regarding to the ticket label scenarios. I'll get a second opinion if possible. There could be edge cases from other scenarios.

spec/czCustomizableSpec.js Show resolved Hide resolved
buildCommit.js Show resolved Hide resolved
@RomanMinkin
Copy link
Contributor

Hey guys is there a chance this PR can make it in?

Copy link
Member

@leonardoanalista leonardoanalista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leonardoanalista
Copy link
Member

I've just resolved the conflicts and it is ready to be released 👍

@leonardoanalista leonardoanalista merged commit a935f67 into leoforfree:master Mar 13, 2019
@leonardoanalista
Copy link
Member

🎉 This PR is included in version 5.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@RomanMinkin
Copy link
Contributor

@smollweide, @leonardoanalista thank you guys you made my day!

@leonardoanalista
Copy link
Member

sorry for the delay, I'll try to be more active on PR's form now on 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants