Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/master'
Browse files Browse the repository at this point in the history
  • Loading branch information
leonardbf committed Apr 1, 2019
2 parents 14e270b + 415dc61 commit 0fbe40e
Show file tree
Hide file tree
Showing 19,301 changed files with 7,634,861 additions and 1 deletion.
The diff you're trying to view is too large. We only load the first 3000 changed files.
1 change: 1 addition & 0 deletions .azure-pipelines/.prettierrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
singleQuote: true
129 changes: 129 additions & 0 deletions .azure-pipelines/client.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
# External variables:
# ProjectFile - The project to build and test. This variable is defined in pipeline web ui because we want to be able to provide it at queue time and that isn't supported in yaml yet.
# MaxParallelTestJobs - Maximum number of parallel test jobs
# AzConfigConnectionString - The connection string used for testing the AzConfig service. This is set in the pipeline web ui as it needs different values for public vs internal.
# ServiceBusConnectionString - The connection string used for testing the Service Bus service. This is set in the pipeline web ui as it needs different values for public vs internal.

trigger:
- master

variables:
DotNetCoreVersion: '2.1.503'

jobs:
- job: 'Build'

pool:
vmImage: 'vs2017-win2016'

steps:
- task: DotNetCoreInstaller@0
displayName: 'Use .NET Core sdk $(DotNetCoreVersion)'
inputs:
version: '$(DotNetCoreVersion)'

- script: 'dotnet pack $(ProjectFile) -o $(Build.ArtifactStagingDirectory) -warnaserror'
displayName: 'Build and Package'
env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_MULTILEVEL_LOOKUP: 0

- task: PublishBuildArtifacts@1
condition: succeededOrFailed()
displayName: 'Publish Artifacts'
inputs:
ArtifactName: packages

- job: 'Analyze'

dependsOn:
- 'Build'

pool:
vmImage: 'vs2017-win2016'

steps:
- task: UsePythonVersion@0
displayName: 'Use Python 3.6'
inputs:
versionSpec: '3.6'

- script: |
pip install setuptools wheel
pip install doc-warden
ward scan -d $(Build.SourcesDirectory) -c $(Build.SourcesDirectory)/eng/.docsettings.yml
displayName: 'Verify Readmes'
- task: DownloadBuildArtifacts@0
displayName: 'Download Build Artifacts'
condition: and(succeededOrFailed(), ne(variables['Build.Reason'],'PullRequest'))
inputs:
artifactName: packages
downloadPath: $(System.DefaultWorkingDirectory)

- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
displayName: 'Component Detection'
# ComponentGovernance is currently unable to run on pull requests of public projects. Running on
# scheduled builds should be good enough.
condition: and(succeededOrFailed(), ne(variables['Build.Reason'],'PullRequest'))

- job: 'Test'

strategy:
maxParallel: $[ variables['MaxParallelTestJobs'] ]
matrix:
Linux:
OSName: 'Linux'
OSVmImage: 'ubuntu-16.04'
Windows:
OSName: 'Windows'
OSVmImage: 'vs2017-win2016'
MacOs:
OSName: 'MacOS'
OSVmImage: 'macOS-10.13'

pool:
vmImage: '$(OSVmImage)'

steps:
- task: DotNetCoreInstaller@0
displayName: 'Use .NET Core sdk $(DotNetCoreVersion)'
inputs:
version: '$(DotNetCoreVersion)'

- task: DotNetCoreCLI@2
displayName: 'Build & Test (no live tests)'
condition: eq(variables['System.TeamProject'], 'public')
env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_MULTILEVEL_LOOKUP: 0
inputs:
command: test
projects: '$(ProjectFile)'
arguments: --filter TestCategory!=Live --logger trx
publishTestResults: false

- task: DotNetCoreCLI@2
displayName: 'Build & Test (with live tests)'
condition: ne(variables['System.TeamProject'], 'public')
env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
DOTNET_MULTILEVEL_LOOKUP: 0
AZ_CONFIG_CONNECTION: $(AzConfigConnectionString)
AZ_SERVICE_BUS_CONNECTION: $(ServiceBusConnectionString)
inputs:
command: test
projects: '$(ProjectFile)'
arguments: --logger trx
publishTestResults: false

- task: PublishTestResults@2
condition: succeededOrFailed()
inputs:
testResultsFiles: '**/*.trx'
testRunTitle: '$(OSName) DotNet $(DotNetCoreVersion)'
testResultsFormat: 'VSTest'
mergeTestResults: true
127 changes: 127 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,127 @@
# Contribute Code or Provide Feedback for Azure SDK for .NET

This repository contains a set of Azure SDKs for .NET that can be consumed for Microsoft Azure applications.

## Basics

If you would like to become an active contributor to this project, please follow the instructions provided in [Microsoft Azure Projects Contribution Guidelines](http://azure.github.io/guidelines/).

In the Azure Developer Experience, you are at Step 4:

[Design, Build and Describe REST API](https://github.com/Azure/adx-documentation-pr/blob/master/README.md#step-1---design-build-and-describe-rest-api) -> [Get Your Swagger Approved](https://github.com/Azure/adx-documentation-pr/blob/master/README.md#step-2---get-your-swagger-approved) -> _**[Generate Request-Response Style Libraries](https://github.com/Azure/adx-documentation-pr/blob/master/README.md#step-3---generate-request-response-style-libraries)**_ -> [Build Command Line Experiences](https://github.com/Azure/adx-documentation-pr/blob/master/README.md#step-4---build-command-line-experiences)

## Table of Contents

[Before Starting](#before-starting)
- [Onboarding](#onboarding)
- [GitHub Basics](#github-basics)
- [GitHub Workflow](#github-workflow)
- [Forking the Azure/azure-sdk-for-net repository](#forking-the-azureazure-sdk-for-net-repository)
- [Code of Conduct](#code-of-conduct)

[Filing Issues](#filing-issues)

[Making Changes](#making-changes)
- [Pull Requests](#pull-requests)
- [REST API Specs](#rest-api-specs)
- [Pull Request Guidelines](#pull-request-guidelines)
- [Cleaning up commits](#cleaning-up-commits)
- [Breaking changes](#breaking-changes)
- [General guidelines](#general-guidelines)
- [Testing guidelines](#testing-guidelines)
- [SDK generation guidelines](#sdk-generation-guidelines)

## Before Starting

### Onboarding

Before cloning this repository, please make sure you have started in our [documentation repository](https://github.com/Azure/adx-documentation-pr) (you will only have access to that page if you are part of the Azure organization).

### GitHub Basics

#### GitHub Workflow

If you don't have experience with Git and GitHub, some of the terminology and process can be confusing. [Here is a guide to understanding the GitHub flow](https://guides.github.com/introduction/flow/) and [here is a guide to understanding the basic Git commands](https://services.github.com/kit/downloads/github-git-cheat-sheet.pdf).

### Forking the Azure/azure-sdk-for-net repository

Unless you are working with multiple contributors on the same file, we ask that you fork the repository and submit your pull request from there. [Here is a guide to forks in GitHub](https://guides.github.com/activities/forking/).

### Code of Conduct

This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.

## Filing Issues

You can find all of the issues that have been filed in the [Issues](https://github.com/Azure/azure-sdk-for-net/issues) section of the repository.

If you encounter any bugs with Azure SDK for .NET, or would like to request a feature, please file an issue [here](https://github.com/Azure/azure-sdk-for-net/issues/new).

You can find the dates for the next three sprints for Azure SDK for .NET in the [Milestones](https://github.com/Azure/azure-sdk-for-net/milestones) section of the Issue page. Each milestone will display the issues that are being worked on for each corresponding sprint.

## Making Changes

### Pull Requests

You can find all of the pull requests that have been opened in the [Pull Request](https://github.com/Azure/azure-sdk-for-net/pulls) section of the repository.

To open your own pull request, click [here](https://github.com/Azure/azure-sdk-for-net/compare). When creating a pull request, keep the following in mind:
- Make sure you are pointing to the fork and branch that your changes were made in
- Choose the correct branch you want your pull request to be merged into
- The **AutoRest** branch is for code generated from AutoRest
- The **master** branch is for code generated from Hyak; code in this branch is in support mode only
- The **Fluent** branch is for the next generation of Azure SDK Management libraries that implement Fluent interfaces
- The pull request template that is provided **should be filled out**; this is not something that should just be deleted or ignored when the pull request is created
- Deleting or ignoring this template will elongate the time it takes for your pull request to be reviewed
- The SLA for reviewing pull requests is **two business days**

### REST API Specs

Before making any changes to the Azure SDK for .NET repository, the corresponding swagger spec must have been checked into the [Azure REST API Spec](https://github.com/Azure/azure-rest-api-specs) repository.

For more information on how to make changes to the REST API Specs repository, click [here](https://github.com/Azure/azure-rest-api-specs/blob/master/.github/CONTRIBUTING.md).

### Pull Request Guidelines

A pull request template will automatically be included as a part of your PR. Please fill out the checklist as specified. Pull requests **will not be reviewed** unless they include a properly completed checklist.

#### Cleaning up Commits

If you are thinking about making a large change to your SDK, **break up the change into small, logical, testable chunks, and organize your pull requests accordingly**.

Often when a pull request is created with a large number of files changed and/or a large number of lines of code added and/or removed, GitHub will have a difficult time opening up the changes on their site. This forces the Azure SDK for .NET team to use separate software to do a code review on the pull request.

If you find yourself creating a pull request and are unable to see all the changes on GitHub, we recommend **splitting the pull request into multiple pull requests that are able to be reviewed on GitHub**.

If splitting up the pull request is not an option, we recommend **creating individual commits for different parts of the pull request, which can be reviewed individually on GitHub**.

For more information on cleaning up the commits in a pull request, such as how to rebase, squash, and cherry-pick, click [here](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).

#### Breaking Changes

Breaking changes should **not** be introduced into the repository without giving customers at least six months notice. For a description of breaking changes in Azure SDK for .NET, see [here](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/Documentation/breaking-changes.md).

#### General guidelines

The following guidelines must be followed in **EVERY** pull request that is opened.

- Title of the pull request is clear and informative
- There are a small number of commits that each have an informative message
- A description of the changes the pull request makes is included, and a reference to the swagger spec pull request is included if the SDK is being regenerated
- All files have the Microsoft copyright header
- The pull request does not introduce [breaking changes](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/Documentation/breaking-changes.md)

#### Testing Guidelines

The following guidelines must be followed in **EVERY** pull request that is opened.

- Pull request includes test coverage for the included changes


#### SDK Generation Guidelines

The following guidelines must be followed in pull requests that generate an SDK from a swagger spec

- A link to the pull request containing these swagger spec changes have been included in the description of the pull request
- The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code
- The `project.json` and `AssemblyInfo.cs` files have been updated with the new version of the SDK
40 changes: 40 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
---
name: Bug report
about: Create a report to help us improve
title: "[BUG]"
labels: ''
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

***Exception or Stack Trace***
Add the exception log and stack trace if available

**To Reproduce**
Steps to reproduce the behavior:

***Code Snippet***
Add the code snippet that causes the issue.

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Setup (please complete the following information):**
- OS: [e.g. iOS]
- IDE : [e.g. IntelliJ]
- Version of the Library used

**Additional context**
Add any other context about the problem here.

**Information Checklist**
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report
- [ ] Bug Description Added
- [ ] Repro Steps Added
- [ ] Setup information Added
25 changes: 25 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
name: Feature request
about: Suggest an idea for this project
title: "[FEATURE REQ]"
labels: ''
assignees: ''

---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.

**Information Checklist**
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report
- [ ] Description Added
- [ ] Expected solution specified
24 changes: 24 additions & 0 deletions .github/ISSUE_TEMPLATE/question-query-template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
---
name: Question/Query template
about: Use this template to file a question/query for the SDK team
title: "[QUERY]"
labels: ''
assignees: ''

---

**Query/Question**
A clear and concise ask/query.

***Why is this not a Bug or a feature Request?***
A clear explanation of why is this not a bug or a feature request?

**Setup (please complete the following information if applicable):**
- OS: [e.g. iOS]
- IDE : [e.g. IntelliJ]
- Version of the Library used

**Information Checklist**
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report
- [ ] Query Added
- [ ] Setup information Added
27 changes: 27 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<!-- DO NOT DELETE THIS TEMPLATE -->

## Description
<!--
Please add an informative description that covers that changes made by the pull request.
If you are regenerating your SDK based off of a new swagger spec, please add the link to the corresponding swagger spec pull request that has been merged in the azure-rest-api-specs repository
-->

---

This checklist is used to make sure that common guidelines for a pull request are followed.
- [ ] Please add REST spec PR link to the SDK PR
- [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md).**
- [ ] **The pull request does not introduce [breaking changes](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/Documentation/breaking-changes.md).**

### [General Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#general-guidelines)
- [ ] Title of the pull request is clear and informative.
- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).

### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#testing-guidelines)
- [ ] Pull request includes test coverage for the included changes.

### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/AutoRest/.github/CONTRIBUTING.md#sdk-generation-guidelines)
- [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
- [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
- [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK.
Loading

0 comments on commit 0fbe40e

Please sign in to comment.