Fix files shown as IDLE when opened with CustomEditor, add support for *.drawio files #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR, everything seems to be working properly. Just a small idling problem, but I fixed it in the last commit. 👍 |
leonardssh
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening *.drawio files, this extension incorrectly shows the discord status as "Idling":
This also occurs when you preview or edit any file in a non-text-based editor, affecting wide range of files (such as PNG, JPG etc.)
After debugging, it appears to me that
window.activeTextEditorwill always cast toundefinedwhen being opened in such an editor, causing many parts of the code to be unable to retrieve the file name, file location and other information. This PR fixes this issue by obtaining the selected file's URI indirectly, then parsing the required information. I've also added the *.drawio icons in this PR.Hopefully this will be helpful :)