adds assertion to check for deleted contexts #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardt
reviewed
Oct 27, 2020
coreir/context.py
Outdated
| @@ -263,6 +265,7 @@ def delete(self): | |||
| None check for all the API code, instead we assume if this is used that | |||
| the user is certain that the context object will no longer be used. | |||
| """ | |||
| print("DELETING", self) | |||
There was a problem hiding this comment.
We should either remove this so it doesn't pollute stdout or use the logging module so it's surpressed by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can occur if context.delete is called, then the context is used again.