Skip to content

Commit

Permalink
Update PULL_REQUEST_TEMPLATE.md
Browse files Browse the repository at this point in the history
  • Loading branch information
leonelquinteros authored Feb 13, 2018
1 parent d0a0759 commit 4d0fbfd
Showing 1 changed file with 14 additions and 10 deletions.
24 changes: 14 additions & 10 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,31 @@
## Before creating a pull request, please check if you have met all required steps
# Before creating your Pull Request...

**Is this a fix or an improvement?**
- New Pull Requests should include a good description of what's being merged.
- Ideally, all Pull Requests are preceded by a discussion initiated in an Issue on this repository.
- For bug fixes is mandatory to have tests that cover and fail when the bug is present and will pass after this Pull Request.
- For changes and improvements, new tests have to be provided to cover the new features.

- [ ] Fix
- [ ] Improvement

**What does this change implement/fix?**
## What does this change implement/fix?

... *answer here*

...
## Is this a fix or an improvement?

- [ ] Fix
- [ ] Improvement

**Have discussed this change in an issue?**
## Have discussed this change in an issue?

- [ ] Yes
- [ ] No

**Was some test failing because of this issue or change needed?**
## Was some test failing because of this issue or change needed?

- [ ] Yes
- [ ] No

**Are you including tests to cover this change?**
## Are you including tests to cover this change?

- [ ] Yes
- [ ] No

0 comments on commit 4d0fbfd

Please sign in to comment.