Improve type for custom range value #1218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've looked all over the docs and from what it seems when adding a custom range point, it must be in the format of a percentage, e.g.
"50%"
.This PR improves the type for the custom keys to ensure they match the pattern of a percentage as opposed to allowing any string such as
"50 percent"
.Please correct me if I've got this incorrect though, I just see no docs that say these custom values should be anything other than this.
Side note
When installing dependencies via
npm i
, it updatedpackage-lock.json
with the current version of this package, let me know if you want this reverting.