Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module path to package.json #1248

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Add module path to package.json #1248

merged 1 commit into from
Jun 14, 2023

Conversation

mdorda
Copy link
Contributor

@mdorda mdorda commented Jun 14, 2023

Fixes #1247

@leongersen
Copy link
Owner

Thanks for your clear explanation and PR. Would this be a breaking change for anyone?

@mdorda
Copy link
Contributor Author

mdorda commented Jun 14, 2023

It should not be a breaking change in a case it is used correctly. Almost all packages has "main" and "module" definitions in package.json. It is a best practise.

@leongersen leongersen merged commit 23e9d39 into leongersen:master Jun 14, 2023
@leongersen
Copy link
Owner

Thank you!

@abdulrahman305 abdulrahman305 mentioned this pull request Jul 26, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Sep 14, 2024
Open
@grumblegirl grumblegirl mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing module definition in package.json
2 participants
@mdorda @leongersen