Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement drag all when more than two handles are configured #841

Closed
wants to merge 1 commit into from

Conversation

sam9291
Copy link
Contributor

@sam9291 sam9291 commented Nov 22, 2017

This PR fixes the issue #756

I've also updated the documentation accordingly, providing an example of the result.

sample

@leongersen
Copy link
Owner

This looks good. I'll give it a test (and add a unit test or two). Nothing about this pull request would break other features, so I think merging it will be easy. Sorry for not responding earlier; I've been travelling for a while.

@leongersen
Copy link
Owner

I'm closing this PR as it has become stale. I'd be willing to accept a new PR on this feature (the code provided here should be easy to port), if it was made part of the current behaviour flag and tests + documentation were added.

@leongersen leongersen closed this Mar 19, 2019
@fuhquan
Copy link

fuhquan commented Jul 17, 2019

Is this still implementable or adaptable for the latest release? This would solve the last open issue I have with my slider configuration.

@leongersen
Copy link
Owner

Yes, the changes in this PR should be straightforward to port to the current state of the code.

@reshmiram
Copy link

Hi,
Will this feature be implemented in the future? This will be very useful for the application I am working on.
Thanks

@leongersen
Copy link
Owner

@reshmiram Not by me, but if you are willing to submit a PR for this feature I'd be interested. The submission here would need to be updated and have unit tests added.

@reshmiram
Copy link

Thank you for responding quickly. I will give that a go.

reshmiram pushed a commit to reshmiram/noUiSlider that referenced this pull request Dec 13, 2020
… drag all handles; changed check for fixed-drag behaviour; added testDragAllHandles
@leongersen leongersen reopened this May 17, 2021
@leongersen leongersen removed the Feature Feature requests/suggestions label May 17, 2021
@leongersen leongersen added this to the 15.4.0 milestone Aug 12, 2021
leongersen added a commit that referenced this pull request Aug 12, 2021
Co-Authored-By: Samuel Poirier <5232883+sam9291@users.noreply.github.com>
@leongersen
Copy link
Owner

This feature is now available in noUiSlider 15.4.0. Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants