-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bug to download geckodriver on linux 64bit #12
fixed bug to download geckodriver on linux 64bit #12
Conversation
Could you be more specific where I have to change? I dont really understand. |
|
On the webdriverdownloader.py you change the line 320 from |
A consideration: Maybe we should do something like
this seems slightly more consistent. Not a big deal tho... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked for me!
it says "that i dont have permission to edit this file" i tried to sudo gedit ~/usr/lib..../webdriverdownloader it opened a space so i can type but the file isnt there. so i pasted the code from there to the new file but it says that the location doesnt even exist. lol help me pls. XD new to ubuntu and stuff. @LeydenJar anyone? |
@nupator try pasting this in the command line
this will give you some information about the webdriverdownloader package, including the path where it's located. |
WARNING: Package(s) not found: webdriverinstaller |
@LeydenJar ley |
@nupator looks like the package is installed on Try to go there and use the ls command to see what's in there. Maybe navigating like this you can find the file. you want to do something like I just wonder why pip show doesn't give you anything. Maybe you have conflicts between different pips. Are you using a virtual environment? Maybe you should consider it. |
@nupator ok so, the cd command should be used to change the directory. As you specified the path to a .py file, it won't work cause it's a .py file and not a directory. Try to cd on /usr/local/lib/......./dist-packages, then use the ls command to see if you can see the webdriverdownloader.py there. If it is you should be able to use something like |
I couldn’t find the similar code on line 320 it’s some other code their
|
…to determine filename for 64bi linux leonidessaguisagjr/webdriverdownloader#12
So, Even after filtering for the filenames wich matches linux os and that are 64 bit, the list filename still had 2 elements on it.
One was something like 'geckodriver-version.tar.gz' and the other was 'geckodriver-version.tar.gz.asc'
So this was making me fall into that exception
if len(filename) != 1: info_message = "Error, unable to determine correct filename for {0}bit {1}".format(bitness, os_name) logger.error(info_message)
So i just added this filtering to remove anything ending in asc from the filename list. Looks like it should be consistent