Add option to delete files after export #247 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonlatsch
requested changes
Feb 21, 2024
| @@ -98,7 +98,10 @@ class ImageViewerViewModel @Inject constructor( | |||
| currentPhoto ?: return@launch | |||
| currentPhoto!!.id ?: return@launch | |||
|
|
|||
| val success = photoRepository.exportPhoto(currentPhoto!!) | |||
| if (success) onSuccess() else onError() | |||
| photoRepository.exportPhoto(currentPhoto!!).let { | |||
| @@ -100,11 +100,13 @@ | |||
| <!-- EXPORT --> | |||
| <string name="export_are_you_sure">Bist du sucher, dass du %1$d Dateien, zurück in deine Galerie, <b>exportieren</b> willst?</string> | |||
| <string name="export_are_you_sure_this">Bist du sicher, dass du diese Datei, zurück in deine Galerie, <b>exportieren</b> willst?</string> | |||
| <string name="export_and_delete_are_you_sure_this">Sind Sie sicher, dass Sie diese Datei in Ihre Galerie <b>exportieren</b> und löschen möchten?</string> | |||
There was a problem hiding this comment.
In german we use "du" and here are some grammar issues
There was a problem hiding this comment.
Also, please don't use google translate for these translations. Add the english text with a TODO in order for the badges in the README to work.
…geViewerViewModel
leonlatsch
requested changes
Feb 21, 2024
|
@BIBLETUM and maybe you can find other icons for these options. Hard to imagine but maybe you find something in the assets of android studio. If not its ok to leave ic_delete for both |
|
Unfortunately could not find any other matching icons |
leonlatsch
reviewed
Feb 22, 2024
| @@ -249,5 +254,5 @@ | |||
| <!-- Recovery Menu --> | |||
| <string name="recovery_subtitle">Recovery Menu</string> <!-- TODO --> | |||
| <string name="recovery_menu_item_open_photok">Open Photok</string> <!-- TODO --> | |||
| <string name="recovery_subtitle_reset_hide_app">Reset Hide App Setting</string> <!-- TODO --> | |||
This was referenced Feb 22, 2024
leonlatsch
added a commit
that referenced
this pull request
Feb 22, 2024
**Description:** - add german translation for feature implemented in #259 - add missing todo **Tasks:** - [x] Build CI Runs - [x] Code Analysis up to standards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add option to delete files after export
#247
Tasks: