fix: add completion detection to prevent infinite loop when all features done

[rohitpalod]

Summary

• Fixes infinite loop bug when all kanban features are completed
• Agent now exits gracefully when 100% of features are passing
• Single-feature mode now exits after one session

Problem

When all features were marked as passing, the agent would run forever because:

1. The main loop in agent.py had no completion detection
2. The coding prompt instructs Claude to run regression tests BEFORE checking for new features via feature_get_for_regression
3. feature_get_next() returns "All features passing!" but nothing acted on it

This caused Claude to infinitely run regression tests on random passing features.

Solution

Added three completion checks to agent.py:

Check	Location	Purpose
Pre-loop	Before first session	Exits immediately if project already 100% complete
Post-session	After each session	Exits when all features become passing
Single-feature	After session	Exits after one session (orchestrator manages agents)

Test Plan

• Tested with project having 240/240 features passing
• Agent now exits immediately with "ALL FEATURES ALREADY COMPLETE!" message
• Verified normal operation still works (agent continues when features remain)

Changes

+ from progress import count_passing_tests, ...

  while True:
+     # Pre-loop: Exit if already complete
+     if not is_first_run and iteration == 1:
+         if total > 0 and passing == total:
+             print("ALL FEATURES ALREADY COMPLETE!")
+             break

      # ... session runs ...

+     # Post-session: Exit if now complete
+     if total > 0 and passing == total:
+         print("ALL FEATURES COMPLETE!")
+         break
+
+     # Single-feature mode: Exit after one session
+     if feature_id is not None:
+         break

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Agent now automatically detects when all features are passing and displays a completion banner before exiting gracefully.
  • Single-feature mode automatically terminates after the current feature's session completes without waiting for subsequent sessions to run.
  • Enhanced early-exit checks have been added across the session workflow to ensure proper termination behavior in all scenarios.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The agent now detects when all features are complete by checking test pass counts using count_passing_tests(). Early-exit conditions were added at multiple codepaths to gracefully terminate the main loop and prevent unnecessary iterations when all features pass or in single-feature mode.

Changes

Cohort / File(s)	Summary
Early-exit Logic Addition agent.py	Added count_passing_tests, has_features, print_progress_summary, and print_session_header imports from progress module. Integrated completion checks after sessions and in multiple control flow paths (session finish, limit reached scenarios). Added single-feature mode early-exit condition. Prints completion banner and exits loop when all features pass (total > 0 and passing == total).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• Bug: Agent continues indefinitely with regression tests after all features complete #13: Directly addresses the endless regression loop bug by implementing early-exit checks that terminate the main loop when all features are passing, using the newly integrated count_passing_tests function to detect completion state.

Poem

🐰 A loop that ran without an end,
Now finds completion—agents' friend!
When all tests pass, we hop away,
No more infinite loops to stay! 🎉

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately summarizes the main change: adding completion detection to prevent infinite loops when all features are complete.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[leonvanzyl]

Thank you.