Remove changes from validate branch

Makefile

@@ -38,4 +38,4 @@ test-coverage:
 	$(foreach pkg, $(ALL_PACKAGES),\
 	go test -coverprofile=coverage.out -covermode=count $(pkg);\
 	tail -n +2 coverage.out >> coverage-all.out;)
-	@go tool cover -html=coverage-all.out -o coverage.html
+	@go tool cover -html=coverage-all.out -o coverage.html

pkg/config/config.go

@@ -35,31 +35,6 @@ type Configs struct {
 	Tasks map[string][]Task
 }
 
-// Validate config and return a list of errors and warnings. If errors are not critical/only warnings, it returns param `ok` as true, else false
-func (configs *Configs) Validate() ([]error, bool) {
-	var errs []error
-	var warnings []error
-	if len(configs.Tasks) == 0 {
-		warnings = append(warnings, fmt.Errorf("dunner: No tasks defined"))
-	}
-
-	for taskName, tasks := range configs.Tasks {
-		for _, task := range tasks {
-			if task.Image == "" {
-				errs = append(errs, fmt.Errorf(`dunner: [%s] Image repository name cannot be empty`, taskName))
-			}
-			if len(task.Command) == 0 {
-				errs = append(errs, fmt.Errorf("dunner: [%s] Commands not defined for task with image %s", taskName, task.Image))
-			}
-		}
-	}
-	if len(errs) > 0 {
-		errs = append(errs, warnings...)
-		return errs, false
-	}
-	return warnings, true
-}
-
 // GetConfigs reads and parses tasks from the dunner file
 func GetConfigs(filename string) (*Configs, error) {
 	fileContents, err := ioutil.ReadFile(filename)

pkg/config/config_test.go

@@ -54,50 +54,3 @@ test:
 	}
 
 }
-
-func TestConfigs_Validate(t *testing.T) {
-	tasks := make(map[string][]Task, 0)
-	tasks["stats"] = []Task{getSampleTask()}
-	configs := &Configs{Tasks: tasks}
-
-	errs, ok := configs.Validate()
-
-	if !ok || len(errs) != 0 {
-		t.Fatalf("Configs Validation failed, expected to pass")
-	}
-}
-
-func TestConfigs_ValidateWithNoTasks(t *testing.T) {
-	tasks := make(map[string][]Task, 0)
-	configs := &Configs{Tasks: tasks}
-
-	errs, ok := configs.Validate()
-
-	if !ok || len(errs) != 1 {
-		t.Fatalf("Configs validation failed")
-	}
-	if errs[0].Error() != "dunner: No tasks defined" {
-		t.Fatalf("Configs Validation error message not as expected")
-	}
-}
-
-func TestConfigs_ValidateWithParseErrors(t *testing.T) {
-	tasks := make(map[string][]Task, 0)
-	task := Task{Image: "", Command: []string{}}
-	tasks["stats"] = []Task{task}
-	configs := &Configs{Tasks: tasks}
-
-	errs, ok := configs.Validate()
-
-	if ok || len(errs) != 2 {
-		t.Fatalf("Configs validation failed")
-	}
-
-	if errs[0].Error() != "dunner: [stats] Image repository name cannot be empty" || errs[1].Error() != "dunner: [stats] Commands not defined for task with image " {
-		t.Fatalf("Configs Validation error message not as expected")
-	}
-}
-
-func getSampleTask() Task {
-	return Task{Image: "image_name", Command: []string{"node", "--version"}}
-}

pkg/dunner/dunner.go

@@ -32,13 +32,6 @@ func Do(_ *cobra.Command, args []string) {
 	if err != nil {
 		log.Fatal(err)
 	}
-	errs, ok := configs.Validate()
-	for _, err := range errs {
-		log.Error(err)
-	}
-	if !ok {
-		os.Exit(1)
-	}
 
 	execTask(configs, args[0], args[1:])
 }
@@ -98,6 +91,10 @@ func process(configs *config.Configs, s *docker.Step, wg *sync.WaitGroup, args [
 		log.Fatal(err)
 	}
 
+	if s.Image == "" {
+		log.Fatalf(`dunner: image repository name cannot be empty`)
+	}
+
 	pout, err := (*s).Exec()
 	if err != nil {
 		log.Fatal(err)