Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make updates to sync with the new project name #70

Merged
merged 1 commit into from
May 15, 2019

Conversation

ayushjn20
Copy link
Collaborator

@ayushjn20 ayushjn20 commented May 12, 2019

Since the repository name has recently been changed, this PR updates the import statements and relevant links to make the develop branch functional again.
TODO:
Check if

  • Codacy integration badge is still working in README.md.
  • Travis builds still get successful.

Gopkg.lock Outdated
@@ -1,332 +0,0 @@
# This file is autogenerated, do not edit; changes may be undone by the next 'dep ensure'.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Gopkg.lock file deleted?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is a blunder. Apparently, dep ensure did not generate Gopkg.lock the file automatically if deleted. I was trying to update the dependencies as well as support for Golang v1.12.x. I had to make an empty lock file and then run dep ensure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-commited changes, please check.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some new dependencies added here, like protobuf. Are those required?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's a lock file, that means it is automatically generated. I have updated all the dependencies by deleting the lock file first, then initializing an empty one followed bt dep ensure

@apoorvam
Copy link
Collaborator

  • check if all package managers still work correctly, with new name

@ayushjn20
Copy link
Collaborator Author

ayushjn20 commented May 14, 2019

Why is this check required now? I could not get it

* [ ]  check if all package managers still work correctly, with new name

@ayushjn20 ayushjn20 closed this May 14, 2019
@ayushjn20 ayushjn20 deleted the develop branch May 14, 2019 17:01
@ayushjn20 ayushjn20 restored the develop branch May 14, 2019 17:01
@ayushjn20 ayushjn20 reopened this May 14, 2019
@apoorvam
Copy link
Collaborator

@ayushjn20 Some of it references the name of the project/url. For example, https://github.com/leopardslab/homebrew-dunner/blob/master/Formula/dunner.rb#L14

It could be similar in all package managers. Github does redirect in some cases, but it's better to verify.

@ayushjn20
Copy link
Collaborator Author

ayushjn20 commented May 14, 2019

I guess there is only snapcraft package manager is left, apart from Homebrew as of now.
@agentmilindu Could you please check on the snapcraft portal?

@agentmilindu agentmilindu merged commit e87b91d into leopardslab:develop May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants