-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make updates to sync with the new project name #70
Conversation
Gopkg.lock
Outdated
@@ -1,332 +0,0 @@ | |||
# This file is autogenerated, do not edit; changes may be undone by the next 'dep ensure'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is Gopkg.lock
file deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that is a blunder. Apparently, dep ensure
did not generate Gopkg.lock
the file automatically if deleted. I was trying to update the dependencies as well as support for Golang v1.12.x. I had to make an empty lock file and then run dep ensure
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have re-commited changes, please check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some new dependencies added here, like protobuf
. Are those required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It's a lock file, that means it is automatically generated. I have updated all the dependencies by deleting the lock file first, then initializing an empty one followed bt dep ensure
|
Why is this check required now? I could not get it
|
@ayushjn20 Some of it references the name of the project/url. For example, https://github.com/leopardslab/homebrew-dunner/blob/master/Formula/dunner.rb#L14 It could be similar in all package managers. Github does redirect in some cases, but it's better to verify. |
I guess there is only snapcraft package manager is left, apart from Homebrew as of now. |
Since the repository name has recently been changed, this PR updates the import statements and relevant links to make the develop branch functional again.
TODO:
Check if