Improve lineargradient border for TextBox in Light/Dark themes #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
For multi-lined
TextBoxes the border seems wrong. It's using aLinearGradientBrushwith absolute mapping so that the upper border was painted in one brush and the the rest of the border was painted in another brush. for a single lineTextBoxall you would see is a border painted in the upper brush, but a multi-lineTextBoxwould reveal the lower part of a different Brush with no transition.What is the new behavior?
I figure the intent was for a smooth linear transition between the two brushes and that's what's coded in this PR.