Fix/submenu navigation #1013
Merged
Fix/submenu navigation #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and avoid lazy loading for the collections due to XAML parsing issues Lazy loading of the collections won't work because, with the introduction of the dependency properties, XAML parsing bypasses the CLR property wrappers, leading to null collections and errors.
…ix some issues in NavigationViewTop.xaml
github-actions
bot
added
controls
pomianowski
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework
MenuItemsandFooterMenuItemsinNavigationViewandNavigationViewItem. Once fixed, we can showcase submenu items in the Gallery App.Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Submenu styling was already implemented in the NavigationView's Top mode but was omitted from the Gallery App, presumably due to bugs (see #759). The main problem, as I saw it, was the cohesion between
Items,ItemsSourceand their dependency properties (DPs).Traditionally in a wpf
ItemsControl,Itemsis a readonly property of typeItemsCollectionwhich can maintain it's ownItemsSource. In WinUi, it's still readonly but of the more generic typeIList<object>and it comes with a DP.What is the new behavior?
The relationship between
ItemsandItemsSourcehas been redefined. For eachItems/ItemsSourcepair, there is now one collection (ObservableCollection<object>) created in the control's constructor. Lazy loading in the getter proved problematic because XAML bypasses the getter in favor of its own store when a DP is defined. Instead of replacing the collection,ItemsSourcenow clears and updates the collection's elements. TheItemsproperties is now read-only and backed by a read-only dependency property, aligning with conventional WPF/WinUI practices.Added submenu content to the Gallery App
