Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hover behavior for CardControl #1233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix hover behavior for CardControl #1233

wants to merge 1 commit into from

Conversation

Difegue
Copy link
Contributor

@Difegue Difegue commented Sep 24, 2024 •
edited
Loading

Non-actionable cards shouldn't have hover behavior, as per WinUI

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

CardControls behave as if they can be clicked when hovering over them

Issue Number: #447

What is the new behavior?

  • CardControls are inert, as in the Windows Settings app

Other information

@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request release labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomianowski pomianowski Awaiting requested review from pomianowski pomianowski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
controls Changes to the appearance or logic of custom controls. PR Pull request release styles Topic is related to styles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Difegue