Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming fixes #1236

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Theming fixes #1236

wants to merge 2 commits into from

Conversation

Difegue
Copy link
Contributor

@Difegue Difegue commented Sep 24, 2024

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

The placeholder text brush for TextControls is incorrect.
We've also seen that when using a single-line InfoBar, the text isn't centered vertically within the control. (This is also the case for multi-line InfoBars, but it's less jarring..)

image

Issue Number: N/A

What is the new behavior?

  • Fixed brush for placeholder text
  • Fixed margins for InfoBar

Other information

@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request release labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. PR Pull request release styles Topic is related to styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant