Defining a FontSize in a FontIcon should not be overridden by its VisualParent's #1244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
When using a
FontIcon
, itsFontSize
will first take the FontSize of itsVisualParent
if it has one, then be set toDefaultIconFontSize
if it's still at the default WPF FontSize.Both of those actions override whatever FontSize you would set in the FontIcon control itself.
An easy example of this is if I want to have a
HyperlinkButton
with a custom Icon Font Size:Issue Number: N/A
What is the new behavior?
The VisualParent FontSize override now only happens if the FontIcon was using the default WPF FontSize. (as in, no custom sizes were applied)
Other information
There's arguably still a problem with this fix if you want a FontIcon whose size coincidentally matches
SystemFonts.MessageFontSize
within say, a HyperLinkButton with a FontSize of 20. But that'd require deeper architectural changes to handle properly...