Allow setting icons on buttons within dialogs #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to adjust the icons that appear on the buttons within a dialog.
Pull request type
What is the current behavior?
Currently, it is not possible to set an icon on a button that appears within a dialog.
Issue Number: N/A
What is the new behavior?
It is now possible to add an icon to a button within a dialog. This can be useful in cases where a developer wishes to add a link icon to a button which links to a support button. In order to demonstrate this new behavior, a carrot icon has been added to the dialog in the demo app.