Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoSuggestBox refactoring #524

Merged
merged 27 commits into from
Feb 8, 2023
Merged

AutoSuggestBox refactoring #524

merged 27 commits into from
Feb 8, 2023

Conversation

IvanDmitriev1
Copy link
Collaborator

@IvanDmitriev1 IvanDmitriev1 commented Feb 2, 2023 •
edited
Loading

Implements a AutoSuggestBox control almost like in winui 3.
Closes: #454, #489, #281, #353

Pull request type

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

  • You cannot navigate to the suggested elements using the keyboard.

What is the new behavior?

  • You can navigate to the suggested elements using the keyboard.
  • Popup will close if AutoSuggestBox lost focus.

@github-actions github-actions bot added the styles Topic is related to styles label Feb 2, 2023
@github-actions github-actions bot added the controls Changes to the appearance or logic of custom controls. label Feb 4, 2023
@github-actions github-actions bot removed the styles Topic is related to styles label Feb 4, 2023
@IvanDmitriev1 IvanDmitriev1 marked this pull request as ready for review February 4, 2023 05:36
@pomianowski
Copy link
Member

Hi, thanks for trying to improve the AutoSuggestBox. Apart from changing the view model convention for the page and namespaces, everything looks neat. Thanks for your contribution.

@pomianowski
Copy link
Member

Or not, sometimes when I type only one letter, the pop up doesn't show up.

Steps to reproduce

  • Open Gallery app in Debug | Any CPU configuration
  • Type a in the AutoSuggestBox of the main NavigationView
  • Click the clear button of the AutoSuggestBox
  • Type a in the AutoSuggestBox of the main NavigationView, again
  • The popup with suggestions does not show up

image

@pomianowski pomianowski merged commit 0d70824 into lepoco:development Feb 8, 2023
@IvanDmitriev1 IvanDmitriev1 deleted the AutoSuggestBox-refactoring branch February 10, 2023 02:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pomianowski pomianowski pomianowski approved these changes

Assignees
No one assigned
Labels
controls Changes to the appearance or logic of custom controls.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanDmitriev1 @pomianowski