-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ToggleSwitch
add OffContent
and OnContent
#602
Conversation
This change decision is unreasonable, content should be driven by binding variables instead of setting content separately for both states. |
I don't want to bind too many variables to handle this switch change, and I don't want to handle this unique change by converting when there are multiple states such as switch, split, and close, which makes the code bloated. I looked at the WinUI 3 Gallery code and it solved my problem perfectly. With this change you can still use the Content property to set the label, OffContent OnContent is just an option |
🤔行吧…… |
ToggleSwitch
add OffContent
and OnContent
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?