Replacing FontSize property #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the FontSize property from codebehind to style
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
When a UI library is loaded as a plugin in another program (.dll project, instead of a separate single .exe), OverrideMetadata breaks text sizes in the whole application, because it overrides the text size of the whole domain. I suggest not to override DependencyProperty, but to set the value in the style of
As an example, you can run https://github.com/snoopwpf/snoopwpf and notice the increased text size after calling OverrideMetadata, without it this is not observed