Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentDialog restore height during resizing #828

Merged

Conversation

Nice3point
Copy link
Contributor

@Nice3point Nice3point commented Nov 18, 2023

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

The dialogue height is flattened and not restored. Missing Padding in computation?

unknown_2023.11.19-02.52_1.mp4

What is the new behavior?

Height recovery is back

unknown_2023.11.19-02.53.mp4

@Nice3point Nice3point changed the title ContentDialog restore height resize ContentDialog restore height during resizing Nov 19, 2023
@pomianowski pomianowski merged commit df28ac0 into lepoco:development Nov 22, 2023
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2024
@Nice3point Nice3point deleted the development_contentdialog branch December 22, 2024 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants