Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

remove called unsubscribe callbacks from list of callbacks #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjhewitt
Copy link

When unsubscribing from pubsub channels, a reference to expired callbacks was kept.

This change updates the unsubscribe_callbacks list to remove references once a callback has been called

@AeroNotix
Copy link

Any update on this? I'm seeing leaking clients when unsubscribing.

@AeroNotix
Copy link

@sjhewitt If you push/amend the commit, travis will try again, looks like the failures weren't related to your changes.

@AeroNotix
Copy link

Tested this locally, does not fix a client leak when unsubscribing. The websocket example leaks clients. @sjhewitt @leporo any ideas?

@sjhewitt
Copy link
Author

Can you create a failing test case or bit of example code?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants