Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_routes_with_exclusions() unregisters the server fn #3150

Closed
benwis opened this issue Oct 23, 2024 · 1 comment
Closed

generate_routes_with_exclusions() unregisters the server fn #3150

benwis opened this issue Oct 23, 2024 · 1 comment

Comments

@benwis
Copy link
Contributor

benwis commented Oct 23, 2024

Generally we want to exclude a route here if we want to manually create a route in the server router for it. This is useful for middlewares and other things that depend on the ordering of things in the router, and thus we don't want LeptosRoutes to auto generate a route for it.

Currently we're also unregistering the server fn, which confuses people and is not useful. We just want to exclude it from route generation

@gbj
Copy link
Collaborator

gbj commented Oct 23, 2024

A test case for the incorrect behavior and what's inspected instead would be really helpful; I don't think there has been a test case for #2735 or this so it's tricky to know what the actual request is and whether it's being addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants